Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createResource state for errored (typo) #1133

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

thomasvanlankveld
Copy link
Contributor

@thomasvanlankveld thomasvanlankveld commented Mar 17, 2025

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

For createResource, the error state was documented as error, which is incorrect. Fixed it it to be errored.

Related issues & labels

  • Suggested label(s) (optional): 'bug', 'documentation'

For `createResource`, the error state was documented as `error`, which is incorrect. Fixed it it to be `errored`.
Copy link

stackblitz bot commented Mar 17, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit ee90781
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67da0dc904e7b2000866d59b
😎 Deploy Preview https://deploy-preview-1133--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@LadyBluenotes LadyBluenotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) March 19, 2025 00:19
@LadyBluenotes LadyBluenotes merged commit dd580f9 into solidjs:main Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants